Bug 241298

Summary:	[Xcode] Use workspace builds by default in build-webkit
Product:	WebKit	Reporter:	Elliott Williams <emw>
Component:	Tools / Tests	Assignee:	Elliott Williams <emw>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	emw, kkinnunen, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=241508
Bug Depends on:
Bug Blocks:	241295, 241863

Description Elliott Williams 2022-06-03 18:19:00 PDT

`build-webkit --use-workspace` has been functional for some time now, and WebKit is free of XCBuild validation warnings. We can make --use-workspace the default, and speed up EWS and other open-source build workflows.

Comment 1 Radar WebKit Bug Importer 2022-06-03 18:20:06 PDT

<rdar://problem/94375189>

Comment 2 Elliott Williams 2022-06-03 18:20:15 PDT

Pull request: https://github.com/WebKit/WebKit/pull/1306

Comment 3 Elliott Williams 2022-06-09 11:16:32 PDT

Pull request: https://github.com/WebKit/WebKit/pull/1421

Comment 4 Kimmo Kinnunen 2022-06-10 04:37:44 PDT

Hopefully affects bug 241508

Comment 5 Elliott Williams 2022-06-10 16:24:14 PDT

(In reply to Kimmo Kinnunen from comment #4)
> Hopefully affects bug 241508

It should! I've had a post-commit bot testing workspace builds <https://build.webkit.org/#/builders/463>, which sees 1-2 minute incremental builds in the best case.

Comment 6 EWS 2022-06-13 12:21:47 PDT

Committed r295496 (251501@main): <https://commits.webkit.org/251501@main>

Reviewed commits have been landed. Closing PR #1306 and removing active labels.

Comment 7 Kimmo Kinnunen 2022-06-14 03:49:09 PDT

*** Bug 241508 has been marked as a duplicate of this bug. ***