| Summary: | TextureMapper: if an element has both a mask image and reflection, the part of the reflection isn't painted | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||||||||||||||
| Component: | Platform | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | cmarcelo, don.olmstead, ews-watchlist, kondapallykalyan, luiz, magomez, webkit-bug-importer, zdobersek | ||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
Created attachment 459999 [details]
[screenshot] Safari Technology Preview 145
Created attachment 460000 [details]
[screenshot] WinCairo
Created attachment 460001 [details]
[screenshot] AppleWin
AppleWin has a bug that it doesn't show the reflection on the first paint. Resizing window paints the reflection. Google Chrome doesn't paint the reflection in this case. Created attachment 460055 [details]
WIP patch
Created attachment 460116 [details]
WIP patch
Created attachment 460146 [details]
Patch
Created attachment 460148 [details]
mask-and-reflection.html
Comment on attachment 460146 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460146&action=review > Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:452 > + static const size_t OverlapRegionConsolidationThreshold = 4; Where'd this number come from? Comment on attachment 460146 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460146&action=review Thank you for the review. >> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:452 >> + static const size_t OverlapRegionConsolidationThreshold = 4; > > Where'd this number come from? I just copied it from TextureMapperLayer::paintUsingOverlapRegions. It was added by 133852@main. Committed r295514 (251519@main): <https://commits.webkit.org/251519@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460146 [details]. |
Created attachment 459998 [details] test case TextureMapper: if a element has both mask image and reflection, the mask image should clip the reflection