| Summary: | text-align: match-parent on root handles direction incorrectly | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kiet Ho <kiet.ho> |
| Component: | CSS | Assignee: | Tim Nguyen (:ntim) <ntim> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | kiet.ho, ntim, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
|
Description
Kiet Ho
2022-05-31 17:15:39 PDT
We do use the direction of the parent, which is effectively why it's wrong for the WPT: https://webkit-search.igalia.com/webkit/rev/00d01db2338b1568d39aa439334f39f0353d0b00/Source/WebCore/style/StyleBuilderConverter.h#617-622 There's no parent in the WPT, so it should just behave like `text-align: start`. (In reply to Tim Nguyen (:ntim) from comment #1) > We do use the direction of the parent, which is effectively why it's wrong > for the WPT: > https://webkit-search.igalia.com/webkit/rev/ > 00d01db2338b1568d39aa439334f39f0353d0b00/Source/WebCore/style/ > StyleBuilderConverter.h#617-622 > > There's no parent in the WPT, so it should just behave like `text-align: > start`. I see what you mean now - I didn't want to give this a generic "failing WPT test" title, but I also didn't do any digging into the root cause, so I just named it according to my best guess. Pull request: https://github.com/WebKit/WebKit/pull/1208 Committed r295120 (251211@main): <https://commits.webkit.org/251211@main> Reviewed commits have been landed. Closing PR #1208 and removing active labels. |