Bug 241105

Summary: Ensure logical properties have skip-builder
Product: WebKit Reporter: Oriol Brufau <obrufau>
Component: CSSAssignee: Oriol Brufau <obrufau>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, joepeck, macpherson, menard, ntim, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Oriol Brufau 2022-05-30 11:15:30 PDT 
Builder::applyProperty resolves logical properties into physical ones.
So there is no need to define BuilderCustom methods for them.
Thus, most already have skip-builder:true.
However, contain-intrinsic-block-size and contain-intrinsic-inline-size don't have that, and then they have some unnecessary methods in BuilderCustom.
Comment 1 Oriol Brufau 2022-05-30 11:21:01 PDT 
Created attachment 459869 [details]
Patch
Comment 2 Tim Nguyen (:ntim) 2022-05-31 04:06:23 PDT 
Comment on attachment 459869 [details]
Patch

Nice cleanup!
Comment 3 EWS 2022-05-31 06:40:02 PDT 
Committed r295050 (251145@main): <https://commits.webkit.org/251145@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459869 [details].
Comment 4 Radar WebKit Bug Importer 2022-05-31 06:41:13 PDT 
<rdar://problem/94147952>
Comment 5 cathiechen 2022-05-31 06:43:04 PDT 
Thanks, Oriol! The patch looks good to me:)