Bug 241057

Summary: [LFC][FFC] Transition flex-grow computation to flex-basis based
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[fast-cq]Patch ews-feeder: commit-queue-

Description zalan 2022-05-27 21:52:08 PDT
ssia
Comment 1 zalan 2022-05-27 21:56:13 PDT
Created attachment 459825 [details]
[fast-cq]Patch
Comment 2 Antti Koivisto 2022-05-27 22:07:02 PDT
Comment on attachment 459825 [details]
[fast-cq]Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459825&action=review

> Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:299
> +    struct StrechingFlexItem {

very similar to ShrinkingFlexItem
Comment 3 zalan 2022-05-28 07:54:02 PDT
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 459825 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=459825&action=review
> 
> > Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:299
> > +    struct StrechingFlexItem {
> 
> very similar to ShrinkingFlexItem
Yeah, they may converge soon.
Comment 4 EWS 2022-05-28 09:19:03 PDT
Committed r295000 (251098@main): <https://commits.webkit.org/251098@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459825 [details].
Comment 5 Radar WebKit Bug Importer 2022-05-28 09:20:14 PDT
<rdar://problem/94075540>