Bug 241023

Summary:	REGRESSION(r294634): Fix unified build with ContentTypeUtilities.cpp
Product:	WebKit	Reporter:	Olivier Blin <olivier.blin>
Component:	Media	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	aperez, eric.carlson, heycam, jer.noble, loic.yhuel, mcatanzaro, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Olivier Blin 2022-05-27 08:47:57 PDT

ContentTypeUtilities.cpp has been added in r294634, but it can break some unified builds because of such errors:

In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-22.cpp:2:
In file included from ../../Source/WebCore/platform/graphics/CrossfadeGeneratedImage.cpp:27:
In file included from ../../Source/WebCore/platform/graphics/CrossfadeGeneratedImage.h:28:
In file included from ../../Source/WebCore/platform/graphics/FloatSize.h:30:
In file included from ../../Source/WebCore/platform/graphics/IntPoint.h:28:
../../Source/WebCore/platform/graphics/IntSize.h:212:16: error: no type named 'TextStream' in namespace 'WebCore::WTF'; did you mean simply 'TextStream'?
WEBCORE_EXPORT WTF::TextStream& operator<<(WTF::TextStream&, const IntSize&);
               ^~~~~~~~~~~~~~~
               TextStream
WTF/Headers/wtf/Forward.h:160:12: note: 'TextStream' declared here
using WTF::TextStream;
           ^

This is because it can make <wtf/Forward.h> included from the WebCore namespace.

Comment 1 Olivier Blin 2022-05-27 08:50:17 PDT

Pull request: https://github.com/WebKit/WebKit/pull/1099

Comment 2 Radar WebKit Bug Importer 2022-06-03 08:48:12 PDT

<rdar://problem/94347846>

Comment 3 Olivier Blin 2022-06-27 02:48:26 PDT

Fixed by Cameron McCormack in https://commits.webkit.org/251669@main