Bug 24093

Summary: Autofocus inputs don't always honor selector input:focus
Product: WebKit Reporter: Anthony Ricaud <rik>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, kaustubh.ra, michelangelo, rniwa, tkent, webkit.review.bot
Priority: P2 Keywords: HasReduction
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://lachy.id.au/dev/markup/tests/html5/autofocus/016.html
Bug Depends on:    
Bug Blocks: 19264    
Attachments:
Description Flags
Patch for Adding test case none

Anthony Ricaud
Reported 2009-02-23 06:37:16 PST
This test by Lachlan Hunt fails. The focus is good but the field should be green.
Attachments
Patch for Adding test case (1.98 KB, patch)
2011-11-08 01:30 PST, Kaustubh Atrawalkar 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michelangelo De Simone
Comment 1 2009-11-02 14:19:27 PST
*** Bug 31031 has been marked as a duplicate of this bug. ***
Kaustubh Atrawalkar
Comment 2 2011-09-23 03:19:19 PDT
I guess this has been fixed. Can be closed.
Alexey Proskuryakov
Comment 3 2011-09-23 16:53:15 PDT
Should we land this as a regression test?
Kaustubh Atrawalkar
Comment 4 2011-11-08 01:30:55 PST
Created attachment 114010 [details] Patch for Adding test case As this has been already fixed, adding regression test case for the same.
Kent Tamura
Comment 5 2011-11-08 07:09:07 PST
Comment on attachment 114010 [details] Patch for Adding test case View in context: https://bugs.webkit.org/attachment.cgi?id=114010&action=review > LayoutTests/fast/forms/autofocus-input-css-style-change.html:18 > +if (window.layoutTestController) { > + layoutTestController.dumpAsText(); > +} > + > +var test = document.getElementById("test"); > +if (document.defaultView.getComputedStyle(test, null).getPropertyValue('background-color') == "rgb(0, 128, 0)") > + result.innerHTML = "PASS"; The code style is consistent. The first if has {} for 1-line body, and the second if has no {} for 1-line body.
Kent Tamura
Comment 6 2011-11-08 07:09:28 PST
(In reply to comment #5) > The code style is consistent. The first if has {} for 1-line body, and the second if has no {} for 1-line body. consistent -> inconsistent.
Alexey Proskuryakov
Comment 7 2011-11-08 08:47:43 PST
Comment on attachment 114010 [details] Patch for Adding test case The comment seems minor enough to land as is, marking cq+.
WebKit Review Bot
Comment 8 2011-11-08 10:04:26 PST
Comment on attachment 114010 [details] Patch for Adding test case Clearing flags on attachment: 114010 Committed r99582: <http://trac.webkit.org/changeset/99582>
WebKit Review Bot
Comment 9 2011-11-08 10:04:30 PST
All reviewed patches have been landed. Closing bug.
Kaustubh Atrawalkar
Comment 10 2011-11-08 21:48:01 PST
Thanks for the review Kent & Alexey.
Note You need to log in before you can comment on or make changes to this bug.