Bug 240889

Summary: Interop 2021 some flex-aspect-ratio tests failing on wpt.fyi
Product: WebKit Reporter: Sammy Gill <sgill26>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: changseok, dgrogan, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, rbuis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch ews-feeder: commit-queue-

Description Sammy Gill 2022-05-24 15:35:37 PDT 
There are a number of flex-aspect ratio tests failing on wpt.fyi. The following tests are failing:

flex-aspect-ratio-002
flex-aspect-ratio-004
flex-aspect-ratio-025
flex-aspect-ratio-026

https://wpt.fyi/results/css/css-sizing/aspect-ratio?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&q=label%3Ainterop-2021-aspect-ratio
Comment 1 Radar WebKit Bug Importer 2022-05-24 15:35:58 PDT 
<rdar://problem/93862854>
Comment 2 Rob Buis 2022-06-24 04:56:38 PDT 
If you intend to work on this, we could collaborate. I did some patches for two of these in the past:
https://bugs.webkit.org/show_bug.cgi?id=222357
Comment 3 Rob Buis 2022-07-27 02:14:13 PDT 
Created attachment 461240 [details]
Patch
Comment 4 Rob Buis 2022-07-27 06:41:12 PDT 
Created attachment 461242 [details]
Patch
Comment 5 Rob Buis 2022-07-28 07:11:29 PDT 
Created attachment 461270 [details]
Patch
Comment 6 Sammy Gill 2022-08-02 15:46:39 PDT 
Hi Rob,

Which tests are your patches going to be addressing? I'm going to be starting work on the aspect-ratio issues again so I'll be making bug reports for each individual test.
Comment 7 David Grogan 2022-08-03 09:03:15 PDT 
Note https://github.com/w3c/csswg-drafts/issues/6794 which may change flex + aspect-ratio behavior.
Comment 8 Rob Buis 2022-08-03 09:30:45 PDT 
(In reply to Sammy Gill from comment #6)
> Hi Rob,
> 
> Which tests are your patches going to be addressing? I'm going to be
> starting work on the aspect-ratio issues again so I'll be making bug reports
> for each individual test.

Great! I was investigating and I think most flexbox test failures are due to the same root cause, not doing the right calculation for the content size suggestion, this probably applies to flex-aspect-ratio-002|004|025 and maybe even 038/039.

The test flex-aspect-ratio-026.html has the most problems. One problem will be fixed by https://bugs.webkit.org/show_bug.cgi?id=243321. A remaining problem is that the width of some of the divs is 5px too wide, causing the green block to not be continuous. The final problem is when resizing a window, two of the divs will keep getting wider. When I disabled caching of child intrinsic sizes it did not have this bug but I think there were other issues.

Feel free to ping me now and then if needed, these failures are longstanding so it would be cool to see them fixed.