Bug 240837

Summary:	Failing text-indent WPT tests
Product:	WebKit	Reporter:	Kiet Ho <kiet.ho>
Component:	CSS	Assignee:	zalan <zalan>
Status:	NEW ---
Severity:	Normal	CC:	ahmad.saleem792, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified

Description Kiet Ho 2022-05-23 16:03:17 PDT

imported/w3c/web-platform-tests/css/css-text/text-indent/anonymous-flex-item-001.html
imported/w3c/web-platform-tests/css/css-text/text-indent/anonymous-grid-item-001.html

Comment 1 Alexey Proskuryakov 2022-05-23 19:30:49 PDT

*** Bug 240838 has been marked as a duplicate of this bug. ***

Comment 2 Radar WebKit Bug Importer 2022-05-30 16:04:13 PDT

<rdar://problem/94123786>

Comment 3 Ahmad Saleem 2023-10-01 16:54:57 PDT

We are still failing these test case. I think in IFC, we might have to do something here?

InlineFormattingGeometry::computedTextIndent

to account for 'isGridItem()' or 'isFlexItemIncludingDeprecated()'?

Comment 4 zalan 2023-10-01 17:09:26 PDT

(In reply to Ahmad Saleem from comment #3)
> We are still failing these test case. I think in IFC, we might have to do
> something here?
> 
> InlineFormattingGeometry::computedTextIndent
> 
> to account for 'isGridItem()' or 'isFlexItemIncludingDeprecated()'?
Not quite, this is a bug in our "first formatted line" implementation where we assume the first child always produces a visible line (see setIsFirstChildForIntegration). Should be relatively easy to fix as we already have it working for text-box trim.