Bug 240776

Summary: [LFC][FFC] Add support for block direction grow
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description zalan 2022-05-22 13:44:00 PDT
ssia
Comment 1 zalan 2022-05-22 13:48:32 PDT
Created attachment 459650 [details]
Patch
Comment 2 zalan 2022-05-22 15:43:30 PDT
Created attachment 459653 [details]
Patch
Comment 3 Antti Koivisto 2022-05-23 06:04:31 PDT
Comment on attachment 459653 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459653&action=review

> Source/WebCore/layout/formattingContexts/FormattingConstraints.h:69
> -    unsigned m_baseTypeFlags : 2; // OptionSet<BaseTypeFlag>
> +    unsigned m_baseTypeFlags : 3; // OptionSet<BaseTypeFlag>

unrelated?
Comment 4 zalan 2022-05-23 06:19:25 PDT
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 459653 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=459653&action=review
> 
> > Source/WebCore/layout/formattingContexts/FormattingConstraints.h:69
> > -    unsigned m_baseTypeFlags : 2; // OptionSet<BaseTypeFlag>
> > +    unsigned m_baseTypeFlags : 3; // OptionSet<BaseTypeFlag>
> 
> unrelated?
yea from https://trac.webkit.org/changeset/294623/webkit/trunk/Source/WebCore/layout/formattingContexts/FormattingConstraints.h
Comment 5 EWS 2022-05-23 06:49:13 PDT
Committed r294638 (250862@main): <https://commits.webkit.org/250862@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459653 [details].
Comment 6 Radar WebKit Bug Importer 2022-05-23 06:50:16 PDT
<rdar://problem/93756160>