Bug 240754

Summary: Make the StringView(const char*) constructor explicit
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web Template FrameworkAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=241207
https://bugs.webkit.org/show_bug.cgi?id=241380
Bug Depends on: 240687    
Bug Blocks:    

Description Chris Dumez 2022-05-20 23:28:31 PDT 
Make the StringView(const char*) constructor private, to encourage people to use ASCIILiteral / ""_s. StringView::fromLatin1() is still available when the caller really has a non-string literal.
Comment 1 Chris Dumez 2022-05-20 23:49:13 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/879
Comment 2 Chris Dumez 2022-05-23 11:46:21 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/930
Comment 3 EWS 2022-05-25 17:13:48 PDT 
Committed r294852 (250986@main): <https://commits.webkit.org/250986@main>

Reviewed commits have been landed. Closing PR #930 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2022-05-25 17:14:17 PDT 
<rdar://problem/93937438>