| Summary: | RenderObject::containerForRepaint should be able to tell if a full repaint has already been scheduled. | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | bfulgham, changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, mifenton, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 240728 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
zalan
2022-05-20 10:39:07 PDT
Created attachment 459620 [details]
Patch
Created attachment 459621 [details]
Patch
Comment on attachment 459621 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459621&action=review > Source/WebCore/rendering/RenderView.cpp:452 > repaintUsingContainer(repaintContainer, computeRectForRepaint(layoutOverflowRect(), repaintContainer)); Can repaintUsingContainer take a RenderElement& after this change? Created attachment 459625 [details]
Patch
(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 459621 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=459621&action=review > > > Source/WebCore/rendering/RenderView.cpp:452 > > repaintUsingContainer(repaintContainer, computeRectForRepaint(layoutOverflowRect(), repaintContainer)); > > Can repaintUsingContainer take a RenderElement& after this change? Yeah, I've been considering that change for a while, but I don't think we are there yet. After https://bugs.webkit.org/attachment.cgi?id=459627&action=prettypatch, where both repaint and repaintRectangle start replacing null_ptr repaint container with the view(), I think it should be relatively easy to do. Created attachment 459651 [details]
Patch
Committed r294699 (250898@main): <https://commits.webkit.org/250898@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459651 [details]. |