Bug 240675

Summary:	An update to a PR suggests a commit message that fails to copy the commit message from an earlier revision
Product:	WebKit	Reporter:	Simon Fraser (smfr) <simon.fraser>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	NEW ---
Severity:	Normal	CC:	jbedard, simon.fraser, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	239082

Description Simon Fraser (smfr) 2022-05-19 11:18:51 PDT

I've already created a PR from a local branch: https://github.com/WebKit/WebKit/pull/765
Now I want to update that PR, so make some local changes, stage them, and run `git-webkit pr --no-update`

This opens an editor that contains:

Need a short description (OOPS!).
Need the bug URL (OOPS!).

Reviewed by NOBODY (OOPS!).

No new tests (OOPS!).
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::canUseDescendantClippingLayer):

Shouldn't this take the title/bug from the earlier commit on this branch?

Comment 1 Jonathan Bedard 2022-05-19 11:25:01 PDT

You're actually adding a new commit, not amending an existing one.

I think the point about forwarding the bug details stands, though.

Comment 2 Radar WebKit Bug Importer 2022-05-26 11:19:12 PDT

<rdar://problem/93983615>