Bug 240637

Summary: [Linux] GBMBufferSwapchain should only conditionally create linear-formatted buffer objects
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek (Reviews) <zdobersek>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 237649    

Zan Dobersek
Reported 2022-05-19 02:53:19 PDT
Right now, every gbm_bo object created in GBMBufferSwapchain is created in linear format. This shouldn't be the case, giving the graphics driver chance to choose the best possible attributes for the buffer object (e.g. most optimal tiling approach). Currently, linearity is required only in media playback, when falling back onto software decoder, results of which are then copied into the spawned gbm_bo object. In most other cases avoiding linearity might be beneficial, so it should be done. This will most likely be solved by passing the GBMBufferSwapchain constructor or getBuffer() call some specific flags requesting a linear buffer.
Attachments
Zan Dobersek
Comment 1 2022-05-25 07:23:34 PDT
EWS
Comment 2 2022-05-25 10:23:50 PDT
Committed r294803 (250959@main): <https://commits.webkit.org/250959@main> Reviewed commits have been landed. Closing PR #1008 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2022-05-25 10:24:16 PDT
Note You need to log in before you can comment on or make changes to this bug.