Bug 240621

Summary: [git-webkit] Question 'Are you sure want to setup a fork?' always returns 'Yes'
Product: WebKit Reporter: Diego Pino <dpino>
Component: New BugsAssignee: Diego Pino <dpino>
Status: RESOLVED MOVED    
Severity: Normal CC: jbedard
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Diego Pino
Reported 2022-05-18 20:41:07 PDT
[git-webkit] Question 'Are you sure want to setup a fork?' always returns 'Yes'
Attachments
Patch (2.02 KB, patch)
2022-05-18 20:41 PDT, Diego Pino 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Diego Pino
Comment 1 2022-05-18 20:41:16 PDT
Created attachment 459565 [details] Patch
Diego Pino
Comment 2 2022-05-18 20:44:05 PDT
This comparison: ``` option.lower().startswith(response.lower()): ``` is always true when response is an empty string. Thus, the first option is always selected instead of the default option (which is what it's expected when the use doesn't introduce any input).
Diego Pino
Comment 3 2022-05-18 21:20:36 PDT
Pushed it at https://github.com/WebKit/WebKit/pull/764
Note You need to log in before you can comment on or make changes to this bug.