Bug 240573

Summary:	[EWS] links to wrong commit when closing pull request
Product:	WebKit	Reporter:	Michael Catanzaro <mcatanzaro>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	NEW ---
Severity:	Normal	CC:	jbedard, mcatanzaro, ryanhaddad, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	239082

Description Michael Catanzaro 2022-05-18 05:34:32 PDT

In https://github.com/WebKit/WebKit/pull/700#issuecomment-1129482085 the EWS says:

Committed r294379 (250671@main): https://commits.webkit.org/250671@main

But that is a completely different commit than what it landed. What it actually landed was:

https://commits.webkit.org/250676@main

It might be related to the fact that EWS rebased this PR on top of three unrelated commits, although it's not clear how it wound up with the number 250671. It looks like everything landed fine in main, and only the comment in the pull request is wrong.

Comment 1 Michael Catanzaro 2022-05-18 05:38:45 PDT

(In reply to Michael Catanzaro from comment #0)
> only the comment in the pull request is wrong.

Well the same wrong comment is on Bugzilla too: https://bugs.webkit.org/show_bug.cgi?id=240536#c2

Comment 2 Radar WebKit Bug Importer 2022-05-25 05:35:14 PDT

<rdar://problem/93895857>