Bug 240535

Summary: [WPE][GTK] Improve dependency tracking of PDF.js files (and other GResources)
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: PDFAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, mcatanzaro, ntim, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   

Description Michael Catanzaro 2022-05-17 13:32:50 PDT 
In https://github.com/WebKit/WebKit/pull/654#issuecomment-1128776747 we found an issue with CMake incremental builds of PDF.js not working correctly. In that PR, I wound up using CONFIGURE_DEPENDS as a solution, but ideally we should not be using GLOB here at all. The CMake documentation explicitly warns against doing this at https://cmake.org/cmake/help/latest/command/file.html#filesystem.

I modified the generate-pdfjs-gresource-manifest.py script to generate a PdfJSFiles.cmake containing a list of files instead, but might not submit this solution because at https://github.com/WebKit/WebKit/pull/654#issuecomment-1129262642 we received a suggestion to use CMake's DEPFILES feature instead. glib-compile-resources can generate the depfile for us, so this is probably going to be the better approach.
Comment 1 Michael Catanzaro 2022-05-17 17:43:20 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/709
Comment 2 EWS 2022-05-19 13:58:12 PDT 
Committed r294504 (250761@main): <https://commits.webkit.org/250761@main>

Reviewed commits have been landed. Closing PR #709 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-05-19 13:59:15 PDT 
<rdar://problem/93601221>