Bug 240529

Summary:	git webkit setup ignores configured editor
Product:	WebKit	Reporter:	Alexey Proskuryakov <ap>
Component:	Tools / Tests	Assignee:	Jonathan Bedard <jbedard>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	jbedard, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	239082

Description Alexey Proskuryakov 2022-05-17 11:06:00 PDT

I chose default when running git webkit setup, and I have this in my environment:

export SVN_EDITOR=commit-log-editor
export SVN_LOG_EDITOR="/usr/local/bin/bbedit --view-top --wait --resume"

And yet I'm getting vi invoked for writing the commit message. I would expect my environment to be respected for "default".

Comment 1 Radar WebKit Bug Importer 2022-05-18 13:07:46 PDT

<rdar://problem/93521972>

Comment 2 Jonathan Bedard 2022-05-18 16:58:26 PDT

Pull request: https://github.com/WebKit/WebKit/pull/757

Comment 3 Jonathan Bedard 2022-05-18 17:05:52 PDT

Pull request: https://github.com/WebKit/WebKit/pull/758

Comment 4 EWS 2022-05-19 07:56:14 PDT

Committed r294480 (250739@main): <https://commits.webkit.org/250739@main>

Reviewed commits have been landed. Closing PR #757 and removing active labels.

Comment 5 EWS 2022-05-19 10:08:14 PDT

Committed r294489 (250748@main): <https://commits.webkit.org/250748@main>

Reviewed commits have been landed. Closing PR #758 and removing active labels.