Bug 240495

Summary:	REGRESSION (r294215): [ iOS ] Nine focus ring tests are a consistent image failure
Product:	WebKit	Reporter:	Karl Rackler <rackler>
Component:	Layout and Rendering	Assignee:	Karl Rackler <rackler>
Status:	RESOLVED DUPLICATE
Severity:	Normal	CC:	bfulgham, kkinnunen, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:	240452
Bug Blocks:

Description Karl Rackler 2022-05-16 18:12:57 PDT

Description:
fast/css/paint-order-shadow.html
fast/forms/ios/focus-ring-size.html
fast/inline/hidpi-outline-auto-negative-offset-with-border-radius.html
fast/inline/hidpi-outline-auto-with-border-radius-horizontal-ltr.html
fast/inline/hidpi-outline-auto-with-border-radius-horizontal-rtl.html
fast/inline/hidpi-outline-auto-with-border-radius-vertical-ltr.html
fast/inline/hidpi-outline-auto-with-border-radius-vertical-rtl.html
fast/inline/hidpi-outline-auto-with-fractional-radius.html
fast/inline/hidpi-outline-auto-with-one-focusring-rect.html

The first failure I saw on the dashboard was on 5/15/2022 at r294215.  r294215 modified use of WebCore::IOSurface has WebCore::GraphicsContext so that probably introduced the consistent image failure. 

REPRODUCTION STEPS
I can reproduce this on r294215, but unable to reproduce on r294214 or earlier.

Command: 
run-webkit-tests --root 294215 --ios-simulator --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 --iterations 50 --no-retry fast/inline/hidpi-outline-auto-with-border-radius-horizontal-rtl.html

Result: 
Regressions: Unexpected image-only failures (1)
  fast/inline/hidpi-outline-auto-with-border-radius-horizontal-rtl.html [ ImageOnlyFailure ]

History:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=fast%2Finline%2Fhidpi-outline-auto-with-border-radius-horizontal-ltr.html&test=fast%2Finline%2Fhidpi-outline-auto-with-border-radius-vertical-ltr.html&test=fast%2Finline%2Fhidpi-outline-auto-with-border-radius-vertical-rtl.html&test=css3%2Fcolor-filters%2Fsvg%2Fcolor-filter-inline-svg.html&test=fast%2Fcss%2Fpaint-order-shadow.html&test=fast%2Fforms%2Fios%2Ffocus-ring-size.html&test=fast%2Finline%2Fhidpi-outline-auto-with-fractional-radius.html&test=fast%2Finline%2Fhidpi-outline-auto-with-one-focusring-rect.html&test=css3%2Fcolor-filters%2Fsvg%2Fcolor-filter-inline-svg.html&test=fast%2Fcss%2Fpaint-order-shadow.html&test=fast%2Fforms%2Fios%2Ffocus-ring-size.html&limit=50000&platform=ios

Image Diff:
fast/css/paint-order-shadow.html
https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-GPUProcess-arm64-WK2-Tests/250573@main%20(1679)/fast/css/paint-order-shadow-diffs.html

fast/forms/ios/focus-ring-size.html
https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-GPUProcess-arm64-WK2-Tests/250573@main%20(1679)/fast/forms/ios/focus-ring-size-diffs.html

fast/inline/hidpi-outline-auto-negative-offset-with-border-radius.html
https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-GPUProcess-arm64-WK2-Tests/250573@main%20(1679)/fast/inline/hidpi-outline-auto-negative-offset-with-border-radius-diffs.html

fast/inline/hidpi-outline-auto-with-border-radius-horizontal-ltr.html
https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-GPUProcess-arm64-WK2-Tests/250573@main%20(1679)/fast/inline/hidpi-outline-auto-with-border-radius-horizontal-ltr-diffs.html

fast/inline/hidpi-outline-auto-with-border-radius-horizontal-rtl.html
https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-GPUProcess-arm64-WK2-Tests/250573@main%20(1679)/fast/inline/hidpi-outline-auto-with-border-radius-horizontal-rtl-diffs.html

fast/inline/hidpi-outline-auto-with-border-radius-vertical-ltr.html
https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-GPUProcess-arm64-WK2-Tests/250573@main%20(1679)/fast/inline/hidpi-outline-auto-with-border-radius-vertical-ltr-diffs.html

fast/inline/hidpi-outline-auto-with-border-radius-vertical-rtl.html
https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-GPUProcess-arm64-WK2-Tests/250573@main%20(1679)/fast/inline/hidpi-outline-auto-with-border-radius-vertical-rtl-diffs.html

fast/inline/hidpi-outline-auto-with-fractional-radius.html
https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-GPUProcess-arm64-WK2-Tests/250573@main%20(1679)/fast/inline/hidpi-outline-auto-with-fractional-radius-diffs.html

fast/inline/hidpi-outline-auto-with-one-focusring-rect.html
https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-GPUProcess-arm64-WK2-Tests/250573@main%20(1679)/fast/inline/hidpi-outline-auto-with-one-focusring-rect-diffs.html

Comment 1 Radar WebKit Bug Importer 2022-05-16 18:13:18 PDT

<rdar://problem/93385433>

Comment 2 Karl Rackler 2022-05-16 18:27:37 PDT

I have marked these tests as consistent image failures while this issue is investigated.

Comment 3 Karl Rackler 2022-05-16 18:30:25 PDT

Pull request: https://github.com/WebKit/WebKit/pull/659

Comment 4 EWS 2022-05-16 18:33:28 PDT

Test gardening commit r294283 (250627@main): <https://commits.webkit.org/250627@main>

Reviewed commits have been landed. Closing PR #659 and removing active labels.

Comment 5 Simon Fraser (smfr) 2022-05-16 19:21:07 PDT

Looks like the focus rings are missing from the expected results.

Comment 6 Kimmo Kinnunen 2022-05-17 01:55:00 PDT

In r294215 I missed that m_needsSetupContext started as false, and it ends up skipping one of the subtly recursive applyBaseTransformToContext() calls.

This is fixed in bug 240452

Comment 7 Alexey Proskuryakov 2022-05-17 10:20:12 PDT

So this should be marked as a dupe of bug 240452, and test gardening should be reverted?

Comment 8 Karl Rackler 2022-05-17 16:37:02 PDT

Verified https://commits.webkit.org/250637@main resolved this issue.

Comment 9 Karl Rackler 2022-05-17 16:48:12 PDT

Remove gardening.

Comment 10 Karl Rackler 2022-05-17 16:48:17 PDT

Re-opening for pull request https://github.com/WebKit/WebKit/pull/706

Comment 11 EWS 2022-05-17 16:51:09 PDT

Test gardening commit r294363 (250666@main): <https://commits.webkit.org/250666@main>

Reviewed commits have been landed. Closing PR #706 and removing active labels.

Comment 12 Karl Rackler 2022-05-17 17:08:21 PDT


*** This bug has been marked as a duplicate of bug 240452 ***