Bug 240487

Summary: git webkit setup pauses between questions to install modules
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 239082    

Description Alexey Proskuryakov 2022-05-16 16:17:17 PDT 
git webkit setup installs a LOT of modules, including between asking questions. This is fairly annoying, it would be better to get them all at once (or to use fewer), so that one didn't have to stare at installation process.

$ git webkit setup
Downloading setuptools-56.2.0...
Installing setuptools-56.2.0...
Installed setuptools-56.2.0!
Downloading setuptools-scm-5.0.2...
Installing setuptools-scm-5.0.2...
Installed setuptools-scm-5.0.2!
Downloading wheel-0.35.1...
Installing wheel-0.35.1...
Installed wheel-0.35.1!
Downloading six-1.15.0...
Installing six-1.15.0...
Installed six-1.15.0!
Downloading requests-2.24.0...
Installing requests-2.24.0...
Installed requests-2.24.0!
Downloading urllib3-1.25.10...
Installing urllib3-1.25.10...
Installed urllib3-1.25.10!
Downloading chardet-3.0.4...
Installing chardet-3.0.4...
Installed chardet-3.0.4!
Downloading idna-2.10.0...
Installing idna-2.10.0...
Installed idna-2.10.0!
Downloading PySocks-1.7.1...
Installing PySocks-1.7.1...
Installed PySocks-1.7.1!
Downloading mock-4.0.3...
Installing mock-4.0.3...
Installed mock-4.0.3!
Downloading xmltodict-0.11.0...
Installing xmltodict-0.11.0...
Installed xmltodict-0.11.0!
Downloading certifi-2020.6.20...
Installing certifi-2020.6.20...
Installed certifi-2020.6.20!
Downloading recertifi-1.1.1...
Installing recertifi-1.1.1...
Installed recertifi-1.1.1!
Downloading appleconnectcloak-1.5.0...
Installing appleconnectcloak-1.5.0...
Installed appleconnectcloak-1.5.0!
Downloading radarclient-5.6.0...
Installing radarclient-5.6.0...
Installed radarclient-5.6.0!
Downloading whichcraft-0.6.1...
Installing whichcraft-0.6.1...
Installed whichcraft-0.6.1!
For detailed information about the options configured by this script, please see:
https://github.com/WebKit/WebKit/wiki/Git-Config#Configuration-Options
Would you like to open this URL in your browser? ([Yes]/No): 


Auto-color status, diff, and branch for this repository? ([Yes]/Skip): 
Downloading jinja2-2.11.3...
Installing jinja2-2.11.3...
Installed jinja2-2.11.3!
Downloading MarkupSafe-1.1.1...
Installing MarkupSafe-1.1.1...
Installed MarkupSafe-1.1.1!
Pick a commit message editor for this repository:
    1) [default]
    2) Xcode
    3) TextEdit
    4) vi
    5) open
Comment 1 Radar WebKit Bug Importer 2022-05-18 13:09:19 PDT 
<rdar://problem/93522052>
Comment 2 Jonathan Bedard 2022-05-19 11:11:48 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/794
Comment 3 Jonathan Bedard 2022-05-19 11:34:53 PDT 
PR fixes the fact that imports can happen after we prompt the user for things.

We do need all of these modules, it’s actually pretty spartan. The modules we’re using are basically:

setuptools and it’s dependencies (to install packages)
requests and it’s dependencies (to make http requests)
appleconnectcloak and it’s dependencies (Internal only, for stash authentication)
radarclient and it’s dependencies (Internal only, for radar integration)
whichcraft (cross-platform ‘which’ command)
jinja2 and it’s dependencies (templating for our hooks that allow git-webkit to be repository neutral)
Comment 4 EWS 2022-05-19 12:54:31 PDT 
Committed r294501 (250759@main): <https://commits.webkit.org/250759@main>

Reviewed commits have been landed. Closing PR #794 and removing active labels.