Bug 240484

Summary:	[css-ui] Unexpose remaining media-* appearance values
Product:	WebKit	Reporter:	Tim Nguyen (:ntim) <ntim>
Component:	CSS	Assignee:	Tim Nguyen (:ntim) <ntim>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	akeerthi, webkit-bug-importer, zsun
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Tim Nguyen (:ntim) 2022-05-16 15:30:02 PDT Comment hidden (obsolete)

2 possibilities:
- Remove them entirely if unimplemented/no-op
- guard them behind a setting or useSystemAppearance if used by Apple apps

Comment 1 Radar WebKit Bug Importer 2022-05-16 15:30:19 PDT

<rdar://problem/93376288>

Comment 2 Tim Nguyen (:ntim) 2022-05-16 15:30:32 PDT

Here's the list:
media-controls-dark-bar-background
media-controls-light-bar-background
media-fullscreen-volume-slider
media-fullscreen-volume-slider-thumb
media-play-button
media-slider
media-sliderthumb
media-volume-slider
media-volume-slider-mute-button
media-volume-sliderthumb

Comment 3 Tim Nguyen (:ntim) 2022-05-21 11:28:28 PDT

I'm removing media-controls-dark-bar-background & media-controls-light-bar-background entirely in bug 240756

Comment 4 Tim Nguyen (:ntim) 2022-05-21 12:36:44 PDT

Bug 240760 will remove media-play-button and media-volume-slider-mute.

Comment 5 Tim Nguyen (:ntim) 2022-05-21 12:37:46 PDT

I think the remainder can be made UA sheet-only or/and useSystemAppearance-only.

Comment 6 Tim Nguyen (:ntim) 2022-05-23 10:29:18 PDT

Pull request: https://github.com/WebKit/WebKit/pull/924

Comment 7 EWS 2022-05-23 13:18:33 PDT

Committed r294677 (250886@main): <https://commits.webkit.org/250886@main>

Reviewed commits have been landed. Closing PR #924 and removing active labels.