| Summary: | Private relay should fail closed for third party loads if the main resource was loaded over private relay | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | cdumez, cgarcia, commit-queue, ews-watchlist, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | 240740 | ||||||||||||
| Bug Blocks: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Alex Christensen
2022-05-16 15:21:03 PDT
Created attachment 459458 [details]
Patch
Created attachment 459518 [details]
Patch
Committed r294371 (250670@main): <https://commits.webkit.org/250670@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459518 [details]. Re-opened since this is blocked by bug 240740 Created attachment 459629 [details]
reverting patch
Created attachment 459635 [details]
Patch
I verified that, when opening several news sites, the patch from 5/17 had some differences between whether it calls _setPrivacyProxyFailClosedForUnreachableNonMainHosts on requests to the same hosts, which would cause different TCP connections to be made, which explains the performance regression. I verified that the patch from 5/20 does not do this. Comment on attachment 459635 [details]
Patch
r=me
Committed r294757 (250925@main): <https://commits.webkit.org/250925@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459635 [details]. |