| Summary: | check-webkit-style: validate enums declared with explicit type | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yury Semikhatsky <yurys> | ||||
| Component: | Tools / Tests | Assignee: | Yury Semikhatsky <yurys> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, glenn, hi, jbedard, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yury Semikhatsky
2022-05-16 14:09:52 PDT
Created attachment 459453 [details]
Patch
This was discovered while looking at the style bot failures inhttps://bugs.webkit.org/show_bug.cgi?id=240326 Comment on attachment 459453 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459453&action=review rs=mews > Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:4396 > + '''enum class Type : uint8_t { FIRST, SECOND };''', i'd include some valid test cases too (e.g. `enum class Foo : uint8_t { First, Second }`) Pull request: https://github.com/WebKit/WebKit/pull/688 Comment on attachment 459453 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459453&action=review >> Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:4396 >> + '''enum class Type : uint8_t { FIRST, SECOND };''', > > i'd include some valid test cases too (e.g. `enum class Foo : uint8_t { First, Second }`) Done. Committed r294351 (250659@main): <https://commits.webkit.org/250659@main> Reviewed commits have been landed. Closing PR #688 and removing active labels. |