| Summary: | [WPE][GTK] Add more padding to WebKitWebView vtable | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aperez, bugs-noreply, mcatanzaro |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Bug Depends on: | |||
| Bug Blocks: | 210100 | ||
|
Description
Michael Catanzaro
2022-05-16 12:00:46 PDT
Actually most vtables will no longer be public after bug #243663, except notably WebKitWebView. This object should receive a _very_ healthy amount of padding IMO. So currently the vtable is 29 bytes for GTK, with zero bytes of padding remaining. WPE uses a little bit less and has 5 bytes of padding remaining. Let's go crazy and add 30 bytes. I think we can afford to splurge here because web views are relatively rare. Pull request: https://github.com/WebKit/WebKit/pull/9139 (In reply to Michael Catanzaro from comment #2) > So currently the vtable is 29 bytes for GTK, with zero bytes of padding > remaining. WPE uses a little bit less and has 5 bytes of padding remaining. > > Let's go crazy and add 30 bytes. I think we can afford to splurge here > because web views are relatively rare. Nitpick: 30 *pointer* entries (plus 29 existing). That makes for 236 bytes on 32-bit platforms, and 472 bytes on 64-bit ones. Still reasonable to add that many, I think. Oh yeah... because pointers require more than one byte. You'll never hear me claim to be competent. Committed 259425@main (5737721c0eb3): <https://commits.webkit.org/259425@main> Reviewed commits have been landed. Closing PR #9139 and removing active labels. |