Bug 240460

Summary: Remove abandoned UseScreenCaptureKit preference
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf, youssefdevelops, y_soliman
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Description Brent Fulgham 2022-05-16 09:41:48 PDT 
Remove the abandoned UseScreenCaptureKit feature flag.
Comment 1 Brent Fulgham 2022-05-16 09:43:59 PDT 
Created attachment 459430 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2022-05-16 09:48:41 PDT 
<rdar://problem/93351960>
Comment 3 Brent Fulgham 2022-05-16 10:45:03 PDT 
Created attachment 459436 [details]
Patch
Comment 4 youenn fablet 2022-05-16 11:28:07 PDT 
Comment on attachment 459436 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459436&action=review

> Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:-914
> -    WebCore::ScreenCaptureKitCaptureSource::setEnabled(m_page.preferences().useScreenCaptureKit());

Should we remove ScreenCaptureKitCaptureSource::setEnabled?
Comment 5 Brent Fulgham 2022-05-16 11:57:10 PDT 
Comment on attachment 459436 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459436&action=review

>> Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:-914
>> -    WebCore::ScreenCaptureKitCaptureSource::setEnabled(m_page.preferences().useScreenCaptureKit());
> 
> Should we remove ScreenCaptureKitCaptureSource::setEnabled?

Oh, good point! It's never used now.
Comment 6 Brent Fulgham 2022-05-16 12:02:07 PDT 
Created attachment 459444 [details]
Patch for landing
Comment 7 EWS 2022-05-16 12:04:27 PDT 
ChangeLog entry in Tools/ChangeLog contains OOPS!.
Comment 8 Brent Fulgham 2022-05-16 12:37:20 PDT 
Created attachment 459448 [details]
Patch for landing
Comment 9 EWS 2022-05-16 14:46:10 PDT 
Committed r294264 (250612@main): <https://commits.webkit.org/250612@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459448 [details].