Bug 240460

Summary: Remove abandoned UseScreenCaptureKit preference
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf, youssefdevelops, y_soliman
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Brent Fulgham
Reported 2022-05-16 09:41:48 PDT
Remove the abandoned UseScreenCaptureKit feature flag.
Attachments
Patch (13.10 KB, patch)
2022-05-16 09:43 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (14.94 KB, patch)
2022-05-16 10:45 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch for landing (16.87 KB, patch)
2022-05-16 12:02 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch for landing (16.87 KB, patch)
2022-05-16 12:37 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2022-05-16 09:43:59 PDT
Created attachment 459430 [details] Patch
Radar WebKit Bug Importer
Comment 2 2022-05-16 09:48:41 PDT
<rdar://problem/93351960>
Brent Fulgham
Comment 3 2022-05-16 10:45:03 PDT
Created attachment 459436 [details] Patch
youenn fablet
Comment 4 2022-05-16 11:28:07 PDT
Comment on attachment 459436 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459436&action=review > Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:-914 > - WebCore::ScreenCaptureKitCaptureSource::setEnabled(m_page.preferences().useScreenCaptureKit()); Should we remove ScreenCaptureKitCaptureSource::setEnabled?
Brent Fulgham
Comment 5 2022-05-16 11:57:10 PDT
Comment on attachment 459436 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459436&action=review >> Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:-914 >> - WebCore::ScreenCaptureKitCaptureSource::setEnabled(m_page.preferences().useScreenCaptureKit()); > > Should we remove ScreenCaptureKitCaptureSource::setEnabled? Oh, good point! It's never used now.
Brent Fulgham
Comment 6 2022-05-16 12:02:07 PDT
Created attachment 459444 [details] Patch for landing
EWS
Comment 7 2022-05-16 12:04:27 PDT
ChangeLog entry in Tools/ChangeLog contains OOPS!.
Brent Fulgham
Comment 8 2022-05-16 12:37:20 PDT
Created attachment 459448 [details] Patch for landing
EWS
Comment 9 2022-05-16 14:46:10 PDT
Committed r294264 (250612@main): <https://commits.webkit.org/250612@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459448 [details].
Note You need to log in before you can comment on or make changes to this bug.