Bug 240447

Summary: [css-ui] Unexpose attachment and borderless-attachment appearance values
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: CSSAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, thorton, webkit-bug-importer, zsun
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Tim Nguyen (:ntim) 2022-05-16 01:25:05 PDT 
borderless-attachment should be restricted behind useSystemAppearance. Although I wonder if we could make this work through appearance: auto + borderless attribute, so we can stop exposing the CSS value altogether, though that would require consumers of <attachment> + appearance: borderless-attachment to change to <attachment borderless>.

attachment is implemented via appearance: auto, so we shouldn't need to keep the CSS value around.
Comment 1 Radar WebKit Bug Importer 2022-05-16 01:25:14 PDT 
<rdar://problem/93331974>
Comment 2 Tim Horton 2022-05-16 11:48:31 PDT 
> behind useSystemAppearance

Please use attachmentElementEnabled instead.
Comment 3 Tim Nguyen (:ntim) 2022-05-16 14:37:45 PDT 
Pull Request: https://github.com/WebKit/WebKit/pull/649
Comment 4 EWS 2022-05-16 15:25:44 PDT 
Committed r294267 (250615@main): <https://commits.webkit.org/250615@main>

Reviewed commits have been landed. Closing PR #649 and removing active labels.