| Summary: | [LFC][FFC] Add support for logical ordering | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
zalan
2022-05-15 21:44:21 PDT
Created attachment 459389 [details]
Patch
Created attachment 459419 [details]
Patch
Created attachment 459429 [details]
Patch
Comment on attachment 459429 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459429&action=review > Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:170 > + std::sort(logicalFlexItemList.begin(), logicalFlexItemList.end(), [&] (auto& a, auto& b) { Probably std::stable_sort? Otherwise identical items get ordered randomly. (In reply to Antti Koivisto from comment #4) > Comment on attachment 459429 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=459429&action=review > > > Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:170 > > + std::sort(logicalFlexItemList.begin(), logicalFlexItemList.end(), [&] (auto& a, auto& b) { > > Probably std::stable_sort? Otherwise identical items get ordered randomly. good point! Created attachment 459432 [details]
Patch
Committed r294240 (250598@main): <https://commits.webkit.org/250598@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459432 [details]. |