| Summary: | MockAudioSharedInternalUnit should exit early when being stopped in generateSampleBuffers | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf, youssefdevelops, y_soliman | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
youenn fablet
2022-05-14 11:28:24 PDT
Created attachment 459358 [details]
Patch
Comment on attachment 459358 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459358&action=review > Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm:150 > + Ref<MockAudioSharedInternalUnitState> m_isProducingState; Nit: `m_isProducingState` doesn't seem right, maybee `m_internalState`? (In reply to Eric Carlson from comment #3) > Comment on attachment 459358 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=459358&action=review > > > Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm:150 > > + Ref<MockAudioSharedInternalUnitState> m_isProducingState; > > Nit: `m_isProducingState` doesn't seem right, maybee `m_internalState`? Let's do that in a follow-up on GitHub, bugzilla webkit patch infra has some issues. Committed r294223 (250581@main): <https://commits.webkit.org/250581@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459358 [details]. |