Bug 240362

Summary: Use _adoptEffectiveConfiguration instead of a separate NSURLSession without credentials
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Alex Christensen 2022-05-12 16:12:52 PDT 
Use _adoptEffectiveConfiguration instead of a separate NSURLSession without credentials
Comment 1 Alex Christensen 2022-05-12 16:14:34 PDT 
Created attachment 459256 [details]
Patch
Comment 2 Alex Christensen 2022-05-13 10:13:37 PDT 
Created attachment 459309 [details]
Patch
Comment 3 Alex Christensen 2022-05-16 09:30:48 PDT 
Perf testers say this is a 0.57% performance improvement.
Comment 4 Chris Dumez 2022-05-16 09:32:10 PDT 
Comment on attachment 459309 [details]
Patch

r=me
Comment 5 EWS 2022-05-16 09:50:36 PDT 
Committed r294238 (250596@main): <https://commits.webkit.org/250596@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459309 [details].
Comment 6 Radar WebKit Bug Importer 2022-05-16 09:51:13 PDT 
<rdar://problem/93352198>
Comment 7 Ryan Haddad 2022-05-16 14:37:09 PDT 
Reverted r294238 for reason:

Breaks internal builds

Committed r294261 (250609@trunk): <https://commits.webkit.org/250609@trunk>
Comment 8 Alex Christensen 2022-05-17 13:55:09 PDT 
Created attachment 459513 [details]
Patch
Comment 9 Alex Christensen 2022-05-17 14:47:20 PDT 
Created attachment 459516 [details]
Patch
Comment 10 Alex Christensen 2022-05-26 17:41:05 PDT 
Created attachment 459800 [details]
Patch
Comment 11 EWS 2022-05-26 20:51:12 PDT 
Committed r294927 (251038@main): <https://commits.webkit.org/251038@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459800 [details].