Bug 240334

Summary: Add logging when taking a process assertion synchronously
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
cdumez: review+
Patch for landing none

Description youenn fablet 2022-05-12 01:55:48 PDT
Add logging when taking a process assertion synchronously
Comment 1 youenn fablet 2022-05-12 02:23:41 PDT
Created attachment 459214 [details]
Patch
Comment 2 Chris Dumez 2022-05-13 07:25:28 PDT
Comment on attachment 459214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459214&action=review

> Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:370
> +    RELEASE_LOG(ProcessSuspension, "%p - ProcessAssertion: Trying to take RBS assertion '%{public}s' for process with PID=%d", this, m_reason.utf8().data(), m_pid);

Please put method name in the logging:
ProcessAssertion::acquireSync: not ProcessAssertion:
Comment 3 youenn fablet 2022-05-15 23:20:07 PDT
Created attachment 459402 [details]
Patch for landing
Comment 4 EWS 2022-05-16 00:16:09 PDT
Committed r294222 (250580@main): <https://commits.webkit.org/250580@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459402 [details].
Comment 5 Radar WebKit Bug Importer 2022-05-16 00:17:13 PDT
<rdar://problem/93329781>