Bug 240306
| Summary: | [GStreamer] Refactor video rendering to a new element | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <pnormand> |
| Component: | Platform | Assignee: | Philippe Normand <pnormand> |
| Status: | RESOLVED LATER | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Philippe Normand
Using appsink with pad probes is not great.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Philippe Normand
Pull request: https://github.com/WebKit/WebKit/pull/587
Philippe Normand
This is quite risky actually. If we move to the GstVideoSink base class we loose the unlock/unlock_stop implementations of appsink. We would also loose some flushing handling that is handled in appsink already.
I'd keep this improvement for later. There are too many tasks more important than this one.
For now we can handle the video meta in the existing pad probe, without breaking anything in the critical video rendering code.