Bug 240305

Summary:

REGRESSION(r291038) [GTK][WPE] Fix build without remote inspector

Product:

WebKit

Reporter:

Olivier Blin <olivier.blin>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aperez, bugs-noreply, cgarcia, loic.yhuel, mcatanzaro

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Olivier Blin 2022-05-11 06:38:54 PDT

GLib ports do not build anymore without remote inspector after r291038.

Comment 1 Olivier Blin 2022-05-11 06:50:20 PDT

Created attachment 459163 [details]
Patch

Comment 2 Michael Catanzaro 2022-05-11 07:59:23 PDT

Comment on attachment 459163 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459163&action=review

> Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp:126
>      parameters.inspectorServerAddress = Inspector::RemoteInspector::inspectorServerAddress();

Would be nice to define it conditionally, too, so it doesn't exist at all except when ENABLE(REMOTE_INSPECTOR) is defined. Just a bit more robust to future changes, in case leaving it uninitialized is not OK in the future.

Comment 3 Olivier Blin 2022-05-12 04:06:28 PDT

Created attachment 459220 [details]
Patch

Comment 4 EWS 2022-05-12 07:28:56 PDT

Committed r294103 (250488@main): <https://commits.webkit.org/250488@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459220 [details].