| Summary: | Need to add DYLD_LIBRARY_PATH for XPC services | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Saboff <msaboff> | ||||||||
| Component: | Platform | Assignee: | Michael Saboff <msaboff> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | david_quesada, saam, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Michael Saboff
2022-05-10 13:57:11 PDT
Created attachment 459133 [details]
Speculative Fix
Created attachment 459137 [details]
Updated patch after discussing with David Quesada offline
Comment on attachment 459137 [details] Updated patch after discussing with David Quesada offline View in context: https://bugs.webkit.org/attachment.cgi?id=459137&action=review It's not 100% related (since it's not specific to the staging install path configuration), but along then theme of loading *libraries* in addition to frameworks, could you also update registerDaemonWithLaunchD() in WebPushToolMain.mm? That builds a dictionary of environment variables that currently includes DYLD_FRAMEWORK_PATH, but also needs to include DYLD_LIBRARY_PATH to make sure the whole stack loads all the right code. > Source/WebKit/Configurations/BaseTarget.xcconfig:129 > OTHER_LDFLAGS_VERSIONED_FRAMEWORK_PATH_YES[arch=arm64*][sdk=macosx11*] = -Wl,-dyld_env,DYLD_FRAMEWORK_PATH=$(WK_INSTALL_PATH_PREFIX)/System/Library/StagedFrameworks/Safari; This should set DYLD_LIBRARY_PATH. Updated the bug for the setting of DYLD_LIBRARY_PATH and DLYD_VERSIONED_LIBRARY_PATH environment variables for XPC services. Created attachment 459171 [details]
Updated Patch
Looks good to me. Comment on attachment 459171 [details] Updated Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459171&action=review > Source/WebKit/Configurations/BaseTarget.xcconfig:129 > +OTHER_LDFLAGS_VERSIONED_FRAMEWORK_PATH_YES[arch=arm64*][sdk=macosx11*] = -Wl,-dyld_env,DYLD_FRAMEWORK_PATH=$(WK_INSTALL_PATH_PREFIX)/System/Library/StagedFrameworks/Safari,-dyld_env,DYLD_LIBRARY_PATH=$(WK_INSTALL_PATH_PREFIX)/System/Library/StagedFrameworks/Safari; I don't know why there is a special case for macosx11 on Apple Silicon only, but that's preexisting code, no change. Committed r294072 (250470@main): <https://commits.webkit.org/250470@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459171 [details]. |