| Summary: | Traditional Mongolian script characters incorrectly oriented | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | r12a <ishida> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ahmad.saleem792, bfulgham, fantasai.bugs, ishida, mmaxfield, simon.fraser, webkit-bug-importer, xidorn-webkit, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari 15 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=112488 | ||
|
Description
r12a
2022-05-10 08:38:43 PDT
This has the same root cause as https://bugs.webkit.org/show_bug.cgi?id=212128 Marking as Dupe of Bug 212128 to match Radar state. *** This bug has been marked as a duplicate of bug 212128 *** I had checked bug 212128 before raising this, and concluded that bug 212128 may involve a fix for a small problem that is not necessarily the fix needed for this much more generalised problem. Certainly, for CJK, rotation of punctuation is handled independently from correctly rotating ordinary text. It may be that Mongolian is a special case, but then i still think that bug 212128 should be rather classed as superceded by this issue, and some text should be added to the bug report to indicate that this is a much bigger problem than just fixing parentheses and brackets. I think we would probably fix all of these bugs in a single patch (or single patch series). Under the assumption that we probably only need a single bug to track these incorrectly rotated characters, do you think we should reverse the duping relationship and dup that bug to this one instead? Yeah, that's what i was thinking, since it seems to be a superset that includes the other bug. I agree that it would seem to make sense to fix all in a single patch. Reversing dup direction. *** Bug 212128 has been marked as a duplicate of this bug. *** Blink merge: https://chromium.googlesource.com/chromium/blink/+/e3ba3532accd84e6a0253705595b97556ae7ca67 In my local testing by adding above in WebKit, it progress both test cases mentioned in Comment 0 and also one of WPT: https://wpt.fyi/results/css/css-writing-modes/mongolian-orientation-002.html?label=master&label=experimental&aligned&q=Mongolian (In reply to Ahmad Saleem from comment #9) > Blink merge: > https://chromium.googlesource.com/chromium/blink/+/ > e3ba3532accd84e6a0253705595b97556ae7ca67 > > In my local testing by adding above in WebKit, it progress both test cases > mentioned in Comment 0 and also one of WPT: > > https://wpt.fyi/results/css/css-writing-modes/mongolian-orientation-002. > html?label=master&label=experimental&aligned&q=Mongolian WebKit Source: https://searchfox.org/wubkat/source/Source/WebCore/platform/graphics/FontCascadeFonts.cpp#224 Line 235 & Line 270. (In reply to Ahmad Saleem from comment #10) > (In reply to Ahmad Saleem from comment #9) > > Blink merge: > > https://chromium.googlesource.com/chromium/blink/+/ > > e3ba3532accd84e6a0253705595b97556ae7ca67 > > > > In my local testing by adding above in WebKit, it progress both test cases > > mentioned in Comment 0 and also one of WPT: > > > > https://wpt.fyi/results/css/css-writing-modes/mongolian-orientation-002. > > html?label=master&label=experimental&aligned&q=Mongolian > > WebKit Source: > https://searchfox.org/wubkat/source/Source/WebCore/platform/graphics/ > FontCascadeFonts.cpp#224 > > Line 235 & Line 270. Note - it fixes this as well from other bug: http://www.mongolfont.com/test/webkit/div.html Attempt PR - https://github.com/WebKit/WebKit/pull/20195 Committed 272454@main (6c53862898c9): <https://commits.webkit.org/272454@main> Reviewed commits have been landed. Closing PR #22186 and removing active labels. |