| Summary: | Introduce a canvas-drawImage specific method to get a NativeImage from a video element | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | Media | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, sam, sergio, webkit-bug-importer, youssefdevelops, y_soliman | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2022-05-10 04:50:19 PDT
Created attachment 459110 [details]
Patch
Comment on attachment 459110 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459110&action=review > Source/WebCore/platform/graphics/MediaPlayer.h:479 > + RefPtr<NativeImage> currentNativeImageForCanvasDrawing(); The functions above use the phrasing "ForCurrentTime" rather than just "current". Would be good to stay consistent here:` nativeImageForCanvasDrawingForCurrentTime()` After discussion with Eric, a boolean getter might be a better fit. Created attachment 459146 [details]
Patch
Committed r294057 (250461@main): <https://commits.webkit.org/250461@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459146 [details]. |