| Summary: | [Cocoa] fast/text/international/generic-font-family-language-traditional.html is failing due to language minimization | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | Text | Assignee: | Myles C. Maxfield <mmaxfield> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, mmaxfield, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
|
Description
Chris Dumez
2022-05-09 21:11:19 PDT
cachedUserPrefersSimplified() should probably say static bool cached = computeUserPrefersSimplified(); instead of static bool cached = false; This is kind of interesting. We're saying the language list ["en", "zh-tw"] gets minimized to ["en"], which then removes the signal about whether we should render simplified or traditional Chinese. On one hand, this is kind of good, because the whole point of minimization is to make different browser configurations in the same bucket as identical. On the other hand, it means a user with these language preferences won't get the rendering they expect. I could change the test to just use the language list ["zh-tw"] and I think it would still test the thing it's trying to test, so I guess that's probably the path forward. 🤔 *** Bug 240751 has been marked as a duplicate of this bug. *** *** Bug 240751 has been marked as a duplicate of this bug. *** Landed in https://commits.webkit.org/250878@main. |