Bug 240231

Summary: Add a better mock for audio units used by CoreAudioSharedUnit
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf, youssefdevelops, y_soliman
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing ews-feeder: commit-queue-

youenn fablet
Reported 2022-05-09 06:22:12 PDT
Add a better mock for audio units used by CoreAudioSharedUnit
Attachments
Patch (81.98 KB, patch)
2022-05-09 06:55 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (81.91 KB, patch)
2022-05-10 05:32 PDT, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (81.93 KB, patch)
2022-05-10 05:48 PDT, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (81.96 KB, patch)
2022-05-10 05:53 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (81.93 KB, patch)
2022-05-12 04:16 PDT, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2022-05-09 06:55:29 PDT
Created attachment 459041 [details] Patch
youenn fablet
Comment 2 2022-05-10 05:32:39 PDT
Created attachment 459111 [details] Patch
youenn fablet
Comment 3 2022-05-10 05:48:14 PDT
Created attachment 459112 [details] Patch
youenn fablet
Comment 4 2022-05-10 05:53:51 PDT
Created attachment 459113 [details] Patch
Eric Carlson
Comment 5 2022-05-10 06:28:21 PDT
Comment on attachment 459113 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459113&action=review > Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm:266 > + auto sampleTime = PAL::toMediaTime(startTime).toFloat(); Can you just use `sampleTime = PAL::CMTimeGetSeconds(startTime)`?
youenn fablet
Comment 6 2022-05-11 00:11:22 PDT
(In reply to Eric Carlson from comment #5) > Comment on attachment 459113 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=459113&action=review > > > Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm:266 > > + auto sampleTime = PAL::toMediaTime(startTime).toFloat(); > > Can you just use `sampleTime = PAL::CMTimeGetSeconds(startTime)`? Yes, that seems better.
youenn fablet
Comment 7 2022-05-11 00:12:24 PDT
Comment on attachment 459113 [details] Patch win failure is unrelated. Marking as r?
youenn fablet
Comment 8 2022-05-12 04:16:17 PDT
Created attachment 459221 [details] Patch for landing
EWS
Comment 9 2022-05-12 06:57:29 PDT
Committed r294102 (250487@main): <https://commits.webkit.org/250487@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459221 [details].
Radar WebKit Bug Importer
Comment 10 2022-05-12 06:58:13 PDT
<rdar://problem/93171741>
Note You need to log in before you can comment on or make changes to this bug.