Bug 240184

Summary: Fix adattributiond build in internal build on older macOS
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, emw, mmaxfield, msaboff, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2022-05-06 14:19:46 PDT
Fix adattributiond build in internal build on older macOS
Attachments
Patch (1.97 KB, patch)
2022-05-06 14:21 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (1.74 KB, patch)
2022-05-06 15:50 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2022-05-06 14:21:14 PDT
Created attachment 458974 [details] Patch
Alex Christensen
Comment 2 2022-05-06 14:21:18 PDT
<rdar://problem/92859012>
Alexey Proskuryakov
Comment 3 2022-05-06 14:28:46 PDT
Comment on attachment 458974 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458974&action=review > Source/WebKit/Configurations/adattributiond.xcconfig:24 > +#include "Base.xcconfig" This is not necessary, please remove. Xcode project includes either Base.xcconfing or DebugRelease.xcconfig for all projects.
Alexey Proskuryakov
Comment 4 2022-05-06 14:30:48 PDT
CC'ing some people who recently made similar changes, and would have a keener eye than myself. This looks like an improvement, but I'm uncertain if this covers all other cases besides StagedFrameworks, like Safari Tech Preview.
Alex Christensen
Comment 5 2022-05-06 15:48:48 PDT
Comment on attachment 458974 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458974&action=review >> Source/WebKit/Configurations/adattributiond.xcconfig:24 >> +#include "Base.xcconfig" > > This is not necessary, please remove. Xcode project includes either Base.xcconfing or DebugRelease.xcconfig for all projects. I verified this is not needed. Will remove.
Alex Christensen
Comment 6 2022-05-06 15:50:00 PDT
Created attachment 458979 [details] Patch
EWS
Comment 7 2022-05-06 17:42:39 PDT
Committed r293936 (250382@main): <https://commits.webkit.org/250382@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458979 [details].
Alex Christensen
Comment 8 2022-05-06 20:26:24 PDT
https://bugs.webkit.org/show_bug.cgi?id=240201 fixes some fallout from this.
Note You need to log in before you can comment on or make changes to this bug.