Bug 240178

Summary: [macOS] Content filter blocking shield is not displayed
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ggaren: review+
Patch none

Per Arne Vollan
Reported 2022-05-06 11:34:38 PDT
Content filter blocking shield is not displayed on macOS for blocked URLs.
Attachments
Patch (1.86 KB, patch)
2022-05-06 11:46 PDT, Per Arne Vollan 		ggaren: review+
DetailsFormatted DiffDiff
Patch (1.87 KB, patch)
2022-05-06 15:11 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2022-05-06 11:34:55 PDT
<rdar://91586177>
Per Arne Vollan
Comment 2 2022-05-06 11:46:32 PDT
Created attachment 458966 [details] Patch
Geoffrey Garen
Comment 3 2022-05-06 14:09:52 PDT
Comment on attachment 458966 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458966&action=review r=me > Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:185 > + auto unblocked = false; > + callOnMainThread([decisionHandler, unblocked] { > + decisionHandler(unblocked); > + }); Can unblocked be a local variable rather than a captured variable here?
Per Arne Vollan
Comment 4 2022-05-06 15:02:25 PDT
(In reply to Geoffrey Garen from comment #3) > Comment on attachment 458966 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=458966&action=review > > r=me > > > Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:185 > > + auto unblocked = false; > > + callOnMainThread([decisionHandler, unblocked] { > > + decisionHandler(unblocked); > > + }); > > Can unblocked be a local variable rather than a captured variable here? Yes, that is a good point, will fix. Thanks for reviewing!
Per Arne Vollan
Comment 5 2022-05-06 15:11:07 PDT
Created attachment 458976 [details] Patch
EWS
Comment 6 2022-05-06 17:02:58 PDT
Committed r293931 (250378@main): <https://commits.webkit.org/250378@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458976 [details].
Note You need to log in before you can comment on or make changes to this bug.