Bug 240178

Summary: [macOS] Content filter blocking shield is not displayed
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ggaren: review+
Patch none

Description Per Arne Vollan 2022-05-06 11:34:38 PDT 
Content filter blocking shield is not displayed on macOS for blocked URLs.
Comment 1 Per Arne Vollan 2022-05-06 11:34:55 PDT 
<rdar://91586177>
Comment 2 Per Arne Vollan 2022-05-06 11:46:32 PDT 
Created attachment 458966 [details]
Patch
Comment 3 Geoffrey Garen 2022-05-06 14:09:52 PDT 
Comment on attachment 458966 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458966&action=review

r=me

> Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:185
> +        auto unblocked = false;
> +        callOnMainThread([decisionHandler, unblocked] {
> +            decisionHandler(unblocked);
> +        });

Can unblocked be a local variable rather than a captured variable here?
Comment 4 Per Arne Vollan 2022-05-06 15:02:25 PDT 
(In reply to Geoffrey Garen from comment #3)
> Comment on attachment 458966 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=458966&action=review
> 
> r=me
> 
> > Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:185
> > +        auto unblocked = false;
> > +        callOnMainThread([decisionHandler, unblocked] {
> > +            decisionHandler(unblocked);
> > +        });
> 
> Can unblocked be a local variable rather than a captured variable here?

Yes, that is a good point, will fix.

Thanks for reviewing!
Comment 5 Per Arne Vollan 2022-05-06 15:11:07 PDT 
Created attachment 458976 [details]
Patch
Comment 6 EWS 2022-05-06 17:02:58 PDT 
Committed r293931 (250378@main): <https://commits.webkit.org/250378@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458976 [details].