Bug 240170

Summary:	REGRESSION (r293117): [ iOS ] fast/innerHTML/001.html is a flaky image failure, caused by fast/images/text-recognition/ios/show-data-detector-context-menu.html
Product:	WebKit	Reporter:	Karl Rackler <rackler>
Component:	New Bugs	Assignee:	Karl Rackler <rackler>
Status:	RESOLVED CONFIGURATION CHANGED
Severity:	Normal	CC:	cdumez, megan_gardner, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer, wenson_hsieh, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Karl Rackler 2022-05-06 08:50:50 PDT

Description:
fast/innerHTML/001.html

The first failure I saw on the dashboard was on 4/20/2022 at r293117.  r293117 modified WKContentView and TestRunnerWKWebView so that probably introduced the flaky image failure. 

History:
https://results.webkit.org/?suite=layout-tests&test=fast%2FinnerHTML%2F001.html&platform=ios&limit=50000

Image Diff:
https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-WK2-Tests/250344%40main%20(2494)/fast/innerHTML/001-diffs.html

Comment 1 Radar WebKit Bug Importer 2022-05-06 08:51:06 PDT

<rdar://problem/92862298>

Comment 2 Karl Rackler 2022-05-06 09:08:03 PDT

In trying to repro the issue, I was unable to on r293116, and the next available commit is r293142, but I was not able to find a commit that seemed relevant; due to the lack of commits in that range, I cannot pinpoint what change could have caused this.

Comment 3 Karl Rackler 2022-05-06 09:34:46 PDT

I have marked this test as a flaky image failure while this issue is investigated.

Comment 4 Karl Rackler 2022-05-06 09:39:02 PDT

Pull request: https://github.com/WebKit/WebKit/pull/545

Comment 5 EWS 2022-05-06 09:44:27 PDT

Test gardening commit r293898 (250356@main): <https://commits.webkit.org/250356@main>

Reviewed commits have been landed. Closing PR #545 and removing active labels.

Comment 6 Simon Fraser (smfr) 2022-05-06 09:58:37 PDT

I think we should revert this. The bad test is not fast/innerHTML/001.html, but probably the one before it.

Comment 7 Karl Rackler 2022-05-06 11:34:03 PDT

Pull request: https://github.com/WebKit/WebKit/pull/547

Comment 8 EWS 2022-05-06 14:52:38 PDT

Committed r293924 (250371@main): <https://commits.webkit.org/250371@main>

Reviewed commits have been landed. Closing PR #547 and removing active labels.

Comment 9 Karl Rackler 2022-05-06 15:14:31 PDT

Reopened because the issue is still being investigated.

Comment 10 Karl Rackler 2022-05-06 15:14:40 PDT

Skip the previous test on the same worker that could be contributing to the issue.

Comment 11 Karl Rackler 2022-05-06 15:18:44 PDT

Pull request: https://github.com/WebKit/WebKit/pull/551

Comment 12 EWS 2022-05-06 15:21:31 PDT

Test gardening commit r293927 (250374@main): <https://commits.webkit.org/250374@main>

Reviewed commits have been landed. Closing PR #551 and removing active labels.

Comment 13 Karl Rackler 2022-05-11 08:35:20 PDT

fast/innerHTML/001.html is currently passing after https://commits.webkit.org/250374@main.

History:
https://results.webkit.org/?suite=layout-tests&test=fast%2FinnerHTML%2F001.html&platform=ios&limit=50000