Bug 240157

Summary: Cache the viewport size inside SVGLengthContext
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: SVGAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, kondapallykalyan, pdr, sabouhallawa, schenney, sergio, simon.fraser, webkit-bug-importer, zalan, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Simon Fraser (smfr)
Reported 2022-05-05 23:01:09 PDT
Cache the viewport size inside SVGLengthContext
Attachments
Patch (10.41 KB, patch)
2022-05-05 23:02 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (9.63 KB, patch)
2022-05-06 14:12 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2022-05-05 23:02:38 PDT
Created attachment 458933 [details] Patch
Nikolas Zimmermann
Comment 2 2022-05-06 00:09:21 PDT
Ok, with me. In LBSE downstream we directly cache the whole SVGLengthContext in SVGElement, for the same reason... (some FIXMES already present in the code regarding that)
Simon Fraser (smfr)
Comment 3 2022-05-06 14:12:27 PDT
Created attachment 458972 [details] Patch
alan
Comment 4 2022-05-09 12:29:46 PDT
Comment on attachment 458972 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458972&action=review > Source/WebCore/svg/SVGLengthContext.cpp:290 > - return false; > + return std::nullopt; return { }; > Source/WebCore/svg/SVGLengthContext.cpp:314 > + return std::nullopt; here too
EWS
Comment 5 2022-05-09 13:57:27 PDT
Committed r293989 (250426@main): <https://commits.webkit.org/250426@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458972 [details].
Radar WebKit Bug Importer
Comment 6 2022-05-09 13:58:13 PDT
<rdar://problem/92984418>
Note You need to log in before you can comment on or make changes to this bug.