| Summary: | Cache the viewport size inside SVGLengthContext | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | SVG | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | changseok, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, kondapallykalyan, pdr, sabouhallawa, schenney, sergio, simon.fraser, webkit-bug-importer, zalan, zimmermann | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Simon Fraser (smfr)
2022-05-05 23:01:09 PDT
Created attachment 458933 [details]
Patch
Ok, with me. In LBSE downstream we directly cache the whole SVGLengthContext in SVGElement, for the same reason... (some FIXMES already present in the code regarding that) Created attachment 458972 [details]
Patch
Comment on attachment 458972 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458972&action=review > Source/WebCore/svg/SVGLengthContext.cpp:290 > - return false; > + return std::nullopt; return { }; > Source/WebCore/svg/SVGLengthContext.cpp:314 > + return std::nullopt; here too Committed r293989 (250426@main): <https://commits.webkit.org/250426@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458972 [details]. |