| Summary: | Make the various shouldApplyContainment() functions member functions on RenderElement | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, cdumez, changseok, dino, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, fred.wang, glenn, gyuyoung.kim, jer.noble, jfernandez, kondapallykalyan, mifenton, mmaxfield, pdr, philipj, rbuis, rego, sabouhallawa, schenney, sergio, simon.fraser, svillar, webkit-bug-importer, youssefdevelops, y_soliman, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=240164 | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2022-05-05 22:08:38 PDT
Created attachment 458932 [details]
Patch
Comment on attachment 458932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458932&action=review > Source/WebCore/rendering/RenderElement.h:505 > +inline bool RenderElement::shouldApplyLayoutContainment() const > +{ > + return style().containsLayout() && (!isInline() || isAtomicInlineLevelBox()) && !isRubyText() && (!isTablePart() || isRenderBlockFlow()); > +} at some point these could all be moved to RenderBlock (or maybe even RenderBlockFlow) since the current render tree has this built-in type information. super not important -and also LFC tree does not work like that either. IIRC somebody (Darin?) requested free functions during review, but I am fine with class methods. (In reply to Rob Buis from comment #3) > IIRC somebody (Darin?) requested free functions during review, but I am fine > with class methods. I think it was me, but seeing how all the callers pass *this, I changed my mind :) Committed r293900 (250358@main): <https://commits.webkit.org/250358@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458932 [details]. |