Bug 240132

Summary: Avoid resolving style for elements that only inherit changes from parent
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jbedard, joepeck, kondapallykalyan, macpherson, menard, pdr, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 240770    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

Description Antti Koivisto 2022-05-05 11:21:10 PDT 
We may do unnecessary work in the subtree when an inherited property changes.
Comment 1 Antti Koivisto 2022-05-05 11:23:11 PDT 
Created attachment 458897 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2022-05-06 10:14:39 PDT 
<rdar://problem/92867346>
Comment 3 Antti Koivisto 2022-05-07 04:26:02 PDT 
Created attachment 458998 [details]
Patch
Comment 4 Antti Koivisto 2022-05-07 04:28:08 PDT 
Created attachment 458999 [details]
Patch
Comment 5 Antti Koivisto 2022-05-07 05:14:11 PDT 
Created attachment 459000 [details]
Patch
Comment 6 Antti Koivisto 2022-05-07 06:59:50 PDT 
Created attachment 459001 [details]
Patch
Comment 7 Sam Weinig 2022-05-07 10:50:58 PDT 
Comment on attachment 459001 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459001&action=review

> Source/WebCore/ChangeLog:10
> +        is done by simply running the full style resolution for them sincluding selector matching and

typo: sincluding -> including

> Source/WebCore/ChangeLog:13
> +        In a common case nothing changes in descendants expect the inherited properties. This patch implements

typo. "In a common case" usually we say "In the common case".

> Source/WebCore/css/CSSProperties.json:96
> +        "Indicates that this CSS property can use fast-path inheritance mechanism.",

"Indicates that this CSS property can use fast-path inheritance mechanism.", -> "Indicates that this CSS property can use the fast-path inheritance mechanism.",
Comment 8 Antti Koivisto 2022-05-07 22:57:20 PDT 
Created attachment 459010 [details]
Patch for landing
Comment 9 EWS 2022-05-08 00:13:30 PDT 
Committed r293956 (250402@main): <https://commits.webkit.org/250402@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459010 [details].