| Summary: | Remove usage of PixelBufferConformer in RealtimeOutgoingVideoSourceCocoa | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, simon.fraser, tommyw, webkit-bug-importer, youennf, youssefdevelops, y_soliman | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=240463 https://bugs.webkit.org/show_bug.cgi?id=240348 |
||||||||||
| Attachments: |
|
||||||||||
|
Description
youenn fablet
2022-05-05 05:21:34 PDT
Created attachment 458867 [details]
Patch
Comment on attachment 458867 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458867&action=review r=me once the bots are happy > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitUtilities.mm:251 > + auto result = libyuv::ARGBToI420(static_cast<uint8_t*>(CVPixelBufferGetBaseAddress(pixelBuffer)), The function name suggests it converts BGRA to YUV, but it calls a function that seems to convert ARGB to YUV. Is this correct? (In reply to Eric Carlson from comment #3) > Comment on attachment 458867 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=458867&action=review > > r=me once the bots are happy > > > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitUtilities.mm:251 > > + auto result = libyuv::ARGBToI420(static_cast<uint8_t*>(CVPixelBufferGetBaseAddress(pixelBuffer)), > > The function name suggests it converts BGRA to YUV, but it calls a function > that seems to convert ARGB to YUV. Is this correct? Yes, this is confusing but is covered by tests. The same confusing naming happens in RTCCVPixelBuffer toI420 method. Mac-wk1 failure is legit and is due to the fact we need to pass a CVPixelBUffer to the H264 encoders instead of a webrtc buffer, I'll change this. Created attachment 458879 [details]
Patch for landing
Created attachment 458902 [details]
Patch for landing
Committed r293885 (250343@main): <https://commits.webkit.org/250343@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458902 [details]. |