| Summary: | [bugs.webkit.org] Replace svn.webkit.org in committers autocomplete | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, bahigachahrouk4, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
|
Description
Jonathan Bedard
2022-05-04 15:44:19 PDT
Pull request: https://github.com/WebKit/WebKit/pull/508 Is there any difference in cache expiration? We want it to be cached I think, but also want to revalidate somewhat frequently to pick up updates. (In reply to Alexey Proskuryakov from comment #3) > Is there any difference in cache expiration? We want it to be cached I > think, but also want to revalidate somewhat frequently to pick up updates. There is a difference. svn.webkit.org serves `Cache-Control: max-age=604800`, which is 7 days. This morning, GitHub is serving `expires: Thu, 05 May 2022 15:22:02 GMT`, which is basically 5 minutes. 5 minutes is shorter than I'd want, but I'm not sure I feel strongly enough to make code or services more complicated to fix that. That's probably better than 7 days. (In reply to Alexey Proskuryakov from comment #5) > That's probably better than 7 days. I feel like ideally it would be a few hours, but I think we can live with 5 minutes. Committed r293849 (250319@main): <https://commits.webkit.org/250319@main> Reviewed commits have been landed. Closing PR #508 and removing active labels. |