Bug 240069

Summary:	[ iOS ] fast/css/continuationCrash.html is a consistent failure
Product:	WebKit	Reporter:	Karl Rackler <rackler>
Component:	New Bugs	Assignee:	Karl Rackler <rackler>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	koivisto, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Karl Rackler 2022-05-04 09:09:08 PDT

Description:
fast/css/continuationCrash.html

The first failure that I saw on the dashboard was 4/1/2022 at r292218, but this does not appear relevant to causing this issue.   This test seems to have been a consistent failure since the start, except for gpuprocess with x86_64, which consistently passes.  

History:
https://results.webkit.org/?suite=layout-tests&test=fast%2Fcss%2FcontinuationCrash.html&platform=ios&limit=50000

Diff:
--- /Volumes/Data/worker/Apple-iOS-15-Simulator-Release-WK2-Tests/build/layout-test-results/fast/css/continuationCrash-expected.txt
+++ /Volumes/Data/worker/Apple-iOS-15-Simulator-Release-WK2-Tests/build/layout-test-results/fast/css/continuationCrash-actual.txt
@@ -51,15 +51,15 @@
             RenderBlock (anonymous) at (12,3) size 116x14
               RenderText at (0,0) size 116x14
                 text run at (0,0) width 116: "1. Set outline property"
-          RenderText {#text} at (144,1) size 4x19
-            text run at (144,1) width 4: " "
-          RenderButton {INPUT} at (150,2) size 144x20 [color=#007AFF] [bgcolor=#E9E9EA] [border: (1px solid #FFFFFF)]
-            RenderBlock (anonymous) at (12,3) size 120x14
-              RenderText at (0,0) size 120x14
-                text run at (0,0) width 120: "2. Set display property"
-          RenderText {#text} at (295,1) size 5x19
-            text run at (295,1) width 5: " "
-          RenderButton {INPUT} at (301,2) size 155x20 [color=#007AFF] [bgcolor=#E9E9EA] [border: (1px solid #FFFFFF)]
+          RenderText {#text} at (143,1) size 5x19
+            text run at (143,1) width 5: " "
+          RenderButton {INPUT} at (149,2) size 144x20 [color=#007AFF] [bgcolor=#E9E9EA] [border: (1px solid #FFFFFF)]
+            RenderBlock (anonymous) at (12,3) size 119x14
+              RenderText at (0,0) size 119x14
+                text run at (0,0) width 119: "2. Set display property"
+          RenderText {#text} at (294,1) size 5x19
+            text run at (294,1) width 5: " "
+          RenderButton {INPUT} at (300,2) size 156x20 [color=#007AFF] [bgcolor=#E9E9EA] [border: (1px solid #FFFFFF)]
             RenderBlock (anonymous) at (12,3) size 131x14
               RenderText at (0,0) size 131x14
                 text run at (0,0) width 131: "3. Replace span-element"

Comment 1 Radar WebKit Bug Importer 2022-05-04 09:09:33 PDT

<rdar://problem/92735768>

Comment 2 Karl Rackler 2022-05-04 09:14:33 PDT

I have marked this test as a flaky failure while this issue is investigated.

Comment 3 Karl Rackler 2022-05-04 09:22:15 PDT

Pull request: https://github.com/WebKit/WebKit/pull/493

Comment 4 EWS 2022-05-04 09:24:59 PDT

Test gardening commit r293776 (250255@main): <https://commits.webkit.org/250255@main>

Reviewed commits have been landed. Closing PR #493 and removing active labels.

Comment 5 Karl Rackler 2022-05-04 09:39:26 PDT

REPRODUCTION STEPS
I can reproduce this on ToT ( r293773 ).

Command: 
run-webkit-tests --root 293773 --ios-simulator fast/css/continuationCrash.html

Result:  
Regressions: Unexpected text-only failures (1)
  fast/css/continuationCrash.html [ Failure ]

Comment 6 Karl Rackler 2022-05-18 07:39:14 PDT

There is one part of the test that is one pixel off for iOS.
Rebaseline test.

Comment 7 Karl Rackler 2022-05-18 07:53:24 PDT

Pull request: https://github.com/WebKit/WebKit/pull/722

Comment 8 EWS 2022-05-18 07:55:58 PDT

Test gardening commit r294396 (250690@main): <https://commits.webkit.org/250690@main>

Reviewed commits have been landed. Closing PR #722 and removing active labels.

Comment 9 Karl Rackler 2022-05-18 10:42:16 PDT

Verified test passing after rebaseline.