Bug 240059

Summary: CoreAudioCaptureSource::settingsDidChange should not reconfigure the audio unit if CoreAudioCaptureSource is not started
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf, youssefdevelops, y_soliman
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description youenn fablet 2022-05-04 02:47:56 PDT 
CoreAudioCaptureSource::settingsDidChange should not reconfigure the audio unit if CoreAudioCaptureSource is not started.
This might trigger debug ASSERT hasClients() in CoreAudioSharedUnit::setupAudioUnit in case the audio unit is running for only rendering audio.
Comment 1 youenn fablet 2022-05-04 02:51:23 PDT 
Created attachment 458783 [details]
Patch
Comment 2 youenn fablet 2022-05-09 02:36:51 PDT 
Created attachment 459038 [details]
Patch
Comment 3 EWS 2022-05-09 07:06:31 PDT 
Committed r293972 (250410@main): <https://commits.webkit.org/250410@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 459038 [details].
Comment 4 Radar WebKit Bug Importer 2022-05-09 07:07:15 PDT 
<rdar://problem/92958589>