Bug 240051

Summary:	REGRESSION(r293285): ASSERTION FAILED: m_isConstructed /Volumes/Data/worker/Apple-Monterey-Debug-Build/build/WebKitBuild/Debug/usr/local/include/wtf/NeverDestroyed.h(152) : ..... [T = const WTF::AtomString, AccessTraits = WTF::MainThreadAccessTraits]
Product:	WebKit	Reporter:	Robert Jenner <jenner>
Component:	WebCore Misc.	Assignee:	Chris Dumez <cdumez>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	cdumez, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Robert Jenner 2022-05-03 18:18:15 PDT

TestWebKitAPI.DocumentOrder.Positions

is a constant assertion/crash on Debug only on BigSur and higher, as well as iOS 15.

HISTORY:
https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.DocumentOrder.Positions

TestWebKitAPI.DocumentOrder.Positions
        ASSERTION FAILED: m_isConstructed
        /Volumes/Data/worker/Apple-Monterey-Debug-Build/build/WebKitBuild/Debug/usr/local/include/wtf/NeverDestroyed.h(152) : WTF::LazyNeverDestroyed::PointerType WTF::LazyNeverDestroyed<const WTF::AtomString, WTF::MainThreadAccessTraits>::storagePointerWithoutAccessCheck() const [T = const WTF::AtomString, AccessTraits = WTF::MainThreadAccessTraits]
        1   0x12c067849 WTFCrash
        2   0x134f1ee3b WTFCrashWithInfo(int, char const*, char const*, int)
        3   0x135232c67 WTF::LazyNeverDestroyed<WTF::AtomString const, WTF::MainThreadAccessTraits>::storagePointerWithoutAccessCheck() const
        4   0x135232bf2 WTF::LazyNeverDestroyed<WTF::AtomString const, WTF::MainThreadAccessTraits>::storagePointer() const
        5   0x135232bc5 WTF::LazyNeverDestroyed<WTF::AtomString const, WTF::MainThreadAccessTraits>::get()
        6   0x138bd4850 WebCore::plaintextOnlyAtom()
        7   0x138f049f4 WebCore::TextControlInnerTextElement::updateInnerTextElementEditabilityImpl(bool, bool)
        8   0x138f0489f WebCore::TextControlInnerTextElement::create(WebCore::Document&, bool)
        9   0x138cf5ea5 WebCore::HTMLTextAreaElement::didAddUserAgentShadowRoot(WebCore::ShadowRoot&)
        10  0x138791d11 WebCore::Element::addShadowRoot(WTF::Ref<WebCore::ShadowRoot, WTF::RawPtrTraits<WebCore::ShadowRoot> >&&)
        11  0x1387926c1 WebCore::Element::createUserAgentShadowRoot()
        12  0x1387925da WebCore::Element::ensureUserAgentShadowRoot()
        13  0x138cf5d67 WebCore::HTMLTextAreaElement::create(WebCore::QualifiedName const&, WebCore::Document&, WebCore::HTMLFormElement*)
        14  0x138cf5e4b WebCore::HTMLTextAreaElement::create(WebCore::Document&)
        15  0x10eb3f9ac TestWebKitAPI::DocumentOrder_Positions_Test::TestBody()
        16  0x10f83610b void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)
        17  0x10f7fa51a void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)
        18  0x10f7fa463 testing::Test::Run()
        19  0x10f7fb5e1 testing::TestInfo::Run()
        20  0x10f7fc684 testing::TestSuite::Run()
        21  0x10f80b79b testing::internal::UnitTestImpl::RunAllTests()
        22  0x10f83b04b bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)
        23  0x10f80b15a bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)
        24  0x10f80b045 testing::UnitTest::Run()
        25  0x10eebd591 RUN_ALL_TESTS()
        26  0x10eebd526 TestWebKitAPI::TestsController::run(int, char**)
        27  0x10f7c7f92 main
        28  0x11a1c851e

Comment 1 Radar WebKit Bug Importer 2022-05-03 18:18:35 PDT

<rdar://problem/92705033>

Comment 2 Robert Jenner 2022-05-03 18:34:56 PDT

I was able to reproduce the failure at iOS15 Debug ToT using the following test:

run-api-tests TestWebKitAPI.DocumentOrder.Positions


I was also able to determine the regression point. The test continues to crash as far back as r293285 or 249910@Main, but passes at the commit directly before r293279 or 249909@Main. So it appears that r293285 is what caused this test to start crashing.

Comment 3 Chris Dumez 2022-05-03 19:14:18 PDT

Pull request: https://github.com/WebKit/WebKit/pull/489

Comment 4 EWS 2022-05-03 23:25:51 PDT

Committed r293762 (250241@main): <https://commits.webkit.org/250241@main>

Reviewed commits have been landed. Closing PR #489 and removing active labels.