Bug 240036

Summary: Enable TextCheckingType::Correction on MacCatalyst.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, mifenton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description Megan Gardner 2022-05-03 13:58:24 PDT 
Enable TextCheckingType::Correction on MacCatalyst.
Comment 1 Megan Gardner 2022-05-03 14:00:11 PDT 
Created attachment 458755 [details]
Patch
Comment 2 Wenson Hsieh 2022-05-03 14:03:22 PDT 
rdar://92691014
Comment 3 Wenson Hsieh 2022-05-03 15:27:45 PDT 
Comment on attachment 458755 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458755&action=review

> Source/WebCore/editing/Editor.cpp:2886
> +            for (const auto& range : previousGrammarRanges) {
> +                if (range.location == resultLocation && range.length == resultLength) {
> +                    resultRangeIsAcceptableForReplacement = true;
> +                    break;
> +                }
> +            }

Nit - might be cleaner as

```
resultRangeIsAcceptableForReplacement = previousGrammarRanges.containsIf([&](auto& range) {
    return range.location == resultLocation && range.length == resultLength;
});
```

> Source/WebCore/editing/Editor.cpp:2909
> +                    previousGrammarRanges.append(CharacterRange(resultLocation + detail.range.location, detail.range.length));

Nit - I think we normally write this as `previousGrammarRanges.append({ resultLocation + detail.range.location, detail.range.length });`.
Comment 4 Megan Gardner 2022-05-03 22:58:32 PDT 
Created attachment 458772 [details]
Patch
Comment 5 Megan Gardner 2022-05-03 23:22:50 PDT 
Created attachment 458774 [details]
Patch for landing
Comment 6 EWS 2022-05-04 01:34:57 PDT 
Committed r293766 (250245@main): <https://commits.webkit.org/250245@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 458774 [details].