| Summary: | REGRESSION (r293427): [ iOS ] http/tests/quicklook/same-origin-xmlhttprequest-allowed.html is a constant crash and failure | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Karl Rackler <rackler> | ||||||||
| Component: | JavaScriptCore | Assignee: | Karl Rackler <rackler> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | akeerthi, beidson, cdumez, ews-watchlist, hi, japhet, katherine_cheney, megan_gardner, thorton, webkit-bot-watchers-bugzilla, webkit-bug-importer, wenson_hsieh | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Karl Rackler
2022-05-03 10:40:12 PDT
I have marked this test as a consistent failure and crash while this issue is investigated. Pull request: https://github.com/WebKit/WebKit/pull/479 Test gardening commit r293738 (250226@main): <https://commits.webkit.org/250226@main> Reviewed commits have been landed. Closing PR #479 and removing active labels. Created attachment 458760 [details]
Patch
Created attachment 458761 [details]
Patch
Comment on attachment 458761 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458761&action=review Looks reasonable to me! (It would be nice if Alex, Brady, and/or Chris could take a look too) > Source/WebCore/loader/DocumentLoader.cpp:1217 > +bool DocumentLoader::isLoadingRemoteArchive() Nit - mark this const? > Source/WebCore/loader/DocumentLoader.h:507 > + bool isLoadingRemoteArchive(); (const here too) Created attachment 458820 [details]
Patch for landing
Committed r293790 (250267@main): <https://commits.webkit.org/250267@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458820 [details]. Verified http/tests/quicklook/same-origin-xmlhttprequest-allowed.html is no longer crashing and failing. History: https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fquicklook%2Fsame-origin-xmlhttprequest-allowed.html&platform=ios&limit=50000 |